feat: Phase 5 & 6 — usability, compliance hardening, analytics
Phase 5 (usability + compliance): - In-app notification bell/badge: migration 016 adds read state + per-user RLS + create_in_app_notification SECURITY DEFINER RPC; /api/notifications; wired into incident creation, CAPA assign/verify, escalation cron - Incident closure: new POST /api/incidents/[id]/close (requires verification status + all CAPAs verified); migration 017 locks closed incidents at DB level (update/delete triggers) with append-only incident_addenda + UI panel - Server-side pagination on HSE/supervisor incident inboxes (.range, 25/page) - Investigation form: alcohol/urine test result + witness statement refs (existing schema columns, now editable) - Type-specific intake fields: migration 018 adds incidents.type_details JSONB; whitelist validation; environmental/asset/security/fire field groups in report form; EN/MS/ZH labels; offline queue support - JKKP 8 annual register CSV export (/api/reports/jkkp8) + dashboard button + January statutory deadline banner - Admin page: user invite (service-role client), role/site/active management, site + zone CRUD with QR report links — replaces Phase 0 stub - Evidence gallery thumbnails via Supabase render transform with fallback Phase 6 (analytics): - 12-month stacked trend chart (leading/lagging/other) + top root causes (lib/dashboard/trends.ts pure helpers) - AI rising-risk zones: /api/dashboard/ai/risk-flags aggregates 90-day zone stats, claude-opus-4-8 forced tool_use, panel on HSE + management dashboards, suggestion audit-logged Also fixes 9 pre-existing missing /ims basePath prefixes in client fetches and download links. 132 tests passing, tsc clean, next build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CPf5Rc8QPx6V8KLEEgfKEQ
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { describe, it, expect } from 'vitest'
|
||||
import { validateIncidentInput, type IncidentInput } from '@/lib/incidents/validate'
|
||||
import { validateIncidentInput, validateTypeDetails, type IncidentInput } from '@/lib/incidents/validate'
|
||||
|
||||
const valid: IncidentInput = {
|
||||
zone_token: 'scw1-dock-a-qr-2026',
|
||||
@@ -43,3 +43,42 @@ describe('validateIncidentInput', () => {
|
||||
expect(result.errors).toContain('incident_type is invalid')
|
||||
})
|
||||
})
|
||||
|
||||
describe('validateTypeDetails', () => {
|
||||
it('accepts valid environmental fields and trims strings', () => {
|
||||
const r = validateTypeDetails('environmental', {
|
||||
substance: ' diesel ',
|
||||
containment_deployed: true,
|
||||
})
|
||||
expect(r.ok).toBe(true)
|
||||
expect(r.sanitized).toEqual({ substance: 'diesel', containment_deployed: true })
|
||||
})
|
||||
|
||||
it('returns null sanitized when details empty or undefined', () => {
|
||||
expect(validateTypeDetails('fire', undefined).sanitized).toBeNull()
|
||||
expect(validateTypeDetails('fire', {}).sanitized).toBeNull()
|
||||
})
|
||||
|
||||
it('rejects unknown fields', () => {
|
||||
const r = validateTypeDetails('asset_damage', { equipment_id: 'FLT-3', bogus: 'x' })
|
||||
expect(r.ok).toBe(false)
|
||||
expect(r.errors[0]).toContain('bogus')
|
||||
})
|
||||
|
||||
it('rejects wrong value types', () => {
|
||||
const r = validateTypeDetails('security', { police_reported: 'yes' })
|
||||
expect(r.ok).toBe(false)
|
||||
expect(r.errors[0]).toContain('boolean')
|
||||
})
|
||||
|
||||
it('rejects details for types without extra fields', () => {
|
||||
const r = validateTypeDetails('near_miss', { substance: 'oil' })
|
||||
expect(r.ok).toBe(false)
|
||||
})
|
||||
|
||||
it('drops empty strings from sanitized output', () => {
|
||||
const r = validateTypeDetails('asset_damage', { equipment_id: ' ', loto_applied: false })
|
||||
expect(r.ok).toBe(true)
|
||||
expect(r.sanitized).toEqual({ loto_applied: false })
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user