feat: Phase 5 & 6 — usability, compliance hardening, analytics
Phase 5 (usability + compliance): - In-app notification bell/badge: migration 016 adds read state + per-user RLS + create_in_app_notification SECURITY DEFINER RPC; /api/notifications; wired into incident creation, CAPA assign/verify, escalation cron - Incident closure: new POST /api/incidents/[id]/close (requires verification status + all CAPAs verified); migration 017 locks closed incidents at DB level (update/delete triggers) with append-only incident_addenda + UI panel - Server-side pagination on HSE/supervisor incident inboxes (.range, 25/page) - Investigation form: alcohol/urine test result + witness statement refs (existing schema columns, now editable) - Type-specific intake fields: migration 018 adds incidents.type_details JSONB; whitelist validation; environmental/asset/security/fire field groups in report form; EN/MS/ZH labels; offline queue support - JKKP 8 annual register CSV export (/api/reports/jkkp8) + dashboard button + January statutory deadline banner - Admin page: user invite (service-role client), role/site/active management, site + zone CRUD with QR report links — replaces Phase 0 stub - Evidence gallery thumbnails via Supabase render transform with fallback Phase 6 (analytics): - 12-month stacked trend chart (leading/lagging/other) + top root causes (lib/dashboard/trends.ts pure helpers) - AI rising-risk zones: /api/dashboard/ai/risk-flags aggregates 90-day zone stats, claude-opus-4-8 forced tool_use, panel on HSE + management dashboards, suggestion audit-logged Also fixes 9 pre-existing missing /ims basePath prefixes in client fetches and download links. 132 tests passing, tsc clean, next build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CPf5Rc8QPx6V8KLEEgfKEQ
This commit is contained in:
@@ -0,0 +1,60 @@
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||||
import { createInAppNotifications } from '@/lib/notifications/in-app'
|
||||
import type { SupabaseClient } from '@supabase/supabase-js'
|
||||
|
||||
function makeSupabaseMock(rpcResult: { error: unknown } = { error: null }) {
|
||||
return {
|
||||
rpc: vi.fn().mockResolvedValue(rpcResult),
|
||||
} as unknown as SupabaseClient
|
||||
}
|
||||
|
||||
describe('createInAppNotifications', () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks()
|
||||
})
|
||||
|
||||
it('calls create_in_app_notification RPC once per recipient', async () => {
|
||||
const supabase = makeSupabaseMock()
|
||||
const { created } = await createInAppNotifications(supabase, [
|
||||
{ userId: 'u1', title: 'New incident', link: '/hse/incidents/i1', incidentId: 'i1' },
|
||||
{ userId: 'u2', title: 'New incident', link: '/hse/incidents/i1', incidentId: 'i1' },
|
||||
])
|
||||
expect(created).toBe(2)
|
||||
expect(supabase.rpc).toHaveBeenCalledTimes(2)
|
||||
expect(supabase.rpc).toHaveBeenCalledWith('create_in_app_notification', {
|
||||
p_recipient: 'u1',
|
||||
p_title: 'New incident',
|
||||
p_link: '/hse/incidents/i1',
|
||||
p_incident_id: 'i1',
|
||||
p_capa_id: null,
|
||||
})
|
||||
})
|
||||
|
||||
it('skips entries missing userId or title', async () => {
|
||||
const supabase = makeSupabaseMock()
|
||||
const { created } = await createInAppNotifications(supabase, [
|
||||
{ userId: '', title: 'x' },
|
||||
{ userId: 'u1', title: '' },
|
||||
])
|
||||
expect(created).toBe(0)
|
||||
expect(supabase.rpc).not.toHaveBeenCalled()
|
||||
})
|
||||
|
||||
it('counts only successful inserts when RPC errors', async () => {
|
||||
const supabase = makeSupabaseMock({ error: { message: 'boom' } })
|
||||
const { created } = await createInAppNotifications(supabase, [
|
||||
{ userId: 'u1', title: 'x' },
|
||||
])
|
||||
expect(created).toBe(0)
|
||||
})
|
||||
|
||||
it('deduplicates recipients for the same notification', async () => {
|
||||
const supabase = makeSupabaseMock()
|
||||
const { created } = await createInAppNotifications(supabase, [
|
||||
{ userId: 'u1', title: 'same', incidentId: 'i1' },
|
||||
{ userId: 'u1', title: 'same', incidentId: 'i1' },
|
||||
])
|
||||
expect(created).toBe(1)
|
||||
expect(supabase.rpc).toHaveBeenCalledTimes(1)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user