setia/ims
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(audit): wrap admin + capa mutations with their audit writes in single transactions

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
admin
2026-07-24 06:44:05 +08:00
co-authored by Claude Sonnet 4.6
parent 8acca41ca1
commit 9c67014bb9
5 changed files with 145 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/api/admin/trucks/route.ts
+26 -18
View File
@@ -2,7 +2,7 @@ export const dynamic = 'force-dynamic'
import { NextRequest, NextResponse } from 'next/server'
import { requireAdmin } from '@/lib/auth/require-admin'
import { asAdmin, withUser } from '@/lib/db/with-user'
import { asAdmin } from '@/lib/db/with-user'
import { trucks, incidents } from '@/lib/db/schema'
import { writeAuditLog } from '@/lib/db/audit'
import { eq, sql } from 'drizzle-orm'
@@ -16,14 +16,18 @@ export async function POST(request: NextRequest) {
if (!truck_no) return NextResponse.json({ error: 'truck_no required' }, { status: 422 })
try {
const [truck] = await asAdmin(db =>
db.insert(trucks).values({ truckNo: truck_no, carrier: (body.carrier ?? '').trim() || null }).returning({ id: trucks.id })
)
if (!truck) return NextResponse.json({ error: 'Insert failed' }, { status: 400 })
await withUser(session.sub, async tx => {
await writeAuditLog(tx, 'trucks', truck.id, 'INSERT', { truck_no, carrier: (body.carrier ?? '').trim() || null })
let truckId: string | undefined
await asAdmin(async db => {
await db.transaction(async tx => {
await tx.execute(sql`SELECT set_config('app.user_id', ${session.sub}, true)`)
const [truck] = await tx.insert(trucks).values({ truckNo: truck_no, carrier: (body.carrier ?? '').trim() || null }).returning({ id: trucks.id })
if (!truck) throw new Error('Insert failed')
truckId = truck.id
await writeAuditLog(tx, 'trucks', truck.id, 'INSERT', { truck_no, carrier: (body.carrier ?? '').trim() || null })
})
})
return NextResponse.json({ id: truck.id }, { status: 201 })
if (!truckId) return NextResponse.json({ error: 'Insert failed' }, { status: 400 })
return NextResponse.json({ id: truckId }, { status: 201 })
} catch (e) {
const code = (e as { code?: string }).code
return NextResponse.json(
@@ -44,15 +48,16 @@ export async function PATCH(request: NextRequest) {
db.select().from(trucks).where(eq(trucks.id, body.id!)).limit(1)
)
try {
await asAdmin(db =>
db.update(trucks).set({ active: body.active }).where(eq(trucks.id, body.id!))
)
await asAdmin(async db => {
await db.transaction(async tx => {
await tx.execute(sql`SELECT set_config('app.user_id', ${session.sub}, true)`)
await tx.update(trucks).set({ active: body.active }).where(eq(trucks.id, body.id!))
await writeAuditLog(tx, 'trucks', body.id!, 'admin_update', { active: body.active }, before ?? null)
})
})
} catch {
return NextResponse.json({ error: 'Update failed' }, { status: 500 })
}
await withUser(session.sub, async tx => {
await writeAuditLog(tx, 'trucks', body.id!, 'admin_update', { active: body.active }, before ?? null)
})
return NextResponse.json({ ok: true })
}
@@ -77,7 +82,13 @@ export async function DELETE(request: NextRequest) {
db.select().from(trucks).where(eq(trucks.id, body.id!)).limit(1)
)
try {
await asAdmin(db => db.delete(trucks).where(eq(trucks.id, body.id!)))
await asAdmin(async db => {
await db.transaction(async tx => {
await tx.execute(sql`SELECT set_config('app.user_id', ${session.sub}, true)`)
await tx.delete(trucks).where(eq(trucks.id, body.id!))
await writeAuditLog(tx, 'trucks', body.id!, 'DELETE', null, before ?? null)
})
})
} catch (e) {
const code = (e as { code?: string }).code
return NextResponse.json(
@@ -85,8 +96,5 @@ export async function DELETE(request: NextRequest) {
{ status: code === '23503' ? 409 : 500 },
)
}
await withUser(session.sub, async tx => {
await writeAuditLog(tx, 'trucks', body.id!, 'DELETE', null, before ?? null)
})
return NextResponse.json({ ok: true })
}