Files
ims/app/api/incidents/[id]/similar/route.ts
T
adminandClaude Fable 5 4242af029c fix: code-review findings — closed-incident embedding 503, hardening, dedup
- /api/incidents/[id]/similar: embedding backfill on a closed incident hit
  the closure-lock trigger and turned the whole request into a 503; now
  skips persistence for closed incidents (vector still used for the query)
- addenda: cap body at 5000 chars; include body text in audit_log entry
- admin users PATCH: 404 when target user does not exist (was silent ok)
- extract shared requireAdmin to lib/auth/require-admin.ts (was duplicated
  in admin users + sites routes)
- extract escapeCsv/rowsToCsv to lib/csv.ts (was duplicated in dashboard
  export route and lib/reports/jkkp8.ts)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CPf5Rc8QPx6V8KLEEgfKEQ
2026-07-12 12:45:01 +08:00

59 lines
2.2 KiB
TypeScript

export const dynamic = 'force-dynamic'
import { NextRequest, NextResponse } from 'next/server'
import { createClient } from '@/lib/supabase/server'
import { embedText } from '@/lib/claude/embed'
import { getApiKey } from '@/lib/settings'
export async function GET(
_request: NextRequest,
{ params }: { params: Promise<{ id: string }> }
) {
const { id } = await params
const supabase = await createClient()
const { data: { user }, error: authError } = await supabase.auth.getUser()
if (authError || !user) return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
const { data: profile } = await supabase.from('users').select('role').eq('id', user.id).single()
if (!profile || !['hse', 'admin'].includes(profile.role))
return NextResponse.json({ error: 'Forbidden' }, { status: 403 })
const voyageKey = await getApiKey(supabase, 'VOYAGE_API_KEY')
const { data: incident } = await supabase
.from('incidents')
.select('id, description, embedding, status')
.eq('id', id)
.single()
if (!incident) return NextResponse.json({ error: 'Not found' }, { status: 404 })
const inc = incident as { id: string; description: string; embedding: string | null; status: string }
let embeddingVec: number[]
try {
if (inc.embedding) {
embeddingVec = JSON.parse(inc.embedding) as number[]
} else {
embeddingVec = await embedText(inc.description, voyageKey)
// Closed incidents are locked at the DB level — the trigger would reject
// this backfill. The vector still serves the similarity query below.
if (inc.status !== 'closed') {
const { error: persistError } = await supabase.from('incidents').update({
embedding: `[${embeddingVec.join(',')}]` as unknown as string,
}).eq('id', id)
if (persistError) console.error('embedding backfill error:', persistError)
}
}
} catch {
return NextResponse.json({ error: 'Embedding service unavailable' }, { status: 503 })
}
const { data: similar } = await supabase.rpc('match_incidents', {
query_embedding: `[${embeddingVec.join(',')}]`,
exclude_id: id,
match_count: 5,
})
return NextResponse.json(similar ?? [])
}